webfonts addon #5178
Open
webfonts addon #5178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@Tyriar I am not sure, if the integration testing works correctly atm. There are several tests failing, but the CI does still mark them as successful. 🤔 Example: https://github.com/xtermjs/xterm.js/actions/runs/11170843380/job/31054434727?pr=5178#step:10:491 |
Ugh, this again |
|
Will handle in #5179 |
|
Fixed: #5180 |
|
I have no clue yet, how to test that in the CI. Maybe it is possible to track the font asset loading somehow with playwright. The changing glyph metrics should be spotable though (my demo fonts are quite different from the usual ones). |
|
@Tyriar Added some CI tests, ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the issue #5164 brought up webfonts once more and the other addon is quite outdated, I started to build a new one.
TODO:
Roboto Monofrom client.ts and client.css again